Consolidate or just unify naming of ModelParams.getNonPredictors and ModelBuilder.specialColNames

Description

ModelBuilder.specialColNames (apparently unused) and ModelBuilder.numSpecialCols expose columns like offset, weight or fold if they are present in the training frame.

ModelParameters.getNonPredictors exposes all training columns which are not predictors: this includes the ones above + the response column.

Suggestion

Rename ModelParameters.getNonPredictors and change signature to ModelParameters.specialColNames(boolean includeResponse).
All current usage should then call params.specialColNames(true) instead.

Change signatures of ModelBuilder.specialColNames to ModelBuilder.specialColNames(boolean includeResponse) and ModelBuilder.numSpecialCols(boolean includeResponse).

All current usage should then call mb.numSpecialCols(false) instead.

Your pinned fields
Click on the next to a field label to start pinning.

Assignee

New H2O Bugs

Fix versions

Reporter

Sebastien Poirier